Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svbony sdk update to 1.13.2 #1015

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Conversation

jctk
Copy link
Contributor

@jctk jctk commented Dec 30, 2024

Update SVBONY SDK to 1.13.2

  • Support new camera SV905C2, SV305C Pro
  • Fixup ASCOM software to support SV905C2 and SV305C Pro cameras
  • Fixup exposure time of SV905C2
  • Optimize gain settings of SV905C2

@jctk jctk changed the title Svbony sdk update to 1.12.3 Svbony sdk update to 1.13.2 Dec 30, 2024
@knro knro merged commit 7f612f0 into indilib:master Dec 30, 2024
3 of 4 checks passed
@jctk
Copy link
Contributor Author

jctk commented Jan 11, 2025

Hi @knro ,
It seems that this RP is not reflected in master.
Could you please confirm that?

image

@jctk jctk deleted the SVBONY-SDK-update-to-1.12.3 branch January 11, 2025 08:39
@knro
Copy link
Collaborator

knro commented Jan 11, 2025

It's merged already. You are seeing CI errors which you can ignore.

@jctk
Copy link
Contributor Author

jctk commented Jan 11, 2025

From your environment, have you confirmed that this PR has been committed to GitHub master?

I have confirmed in the indi-3rdparty repository in GitHub that this PR was not committed on December 30 when it was merge.
image

The last commit of the bin files in the master branch of libsvbony was 7 months ago as shown in the screenshot below.
The commit message says Version 1.12.8, which is different from PR's 1.13.2.
image

@knro
Copy link
Collaborator

knro commented Jan 11, 2025

You are correct!! I think a force push might have deleted it. Can you please resubmit again?

@jctk
Copy link
Contributor Author

jctk commented Jan 11, 2025

I have recommited the PR as #1021.

Note:
There seems to be another missing commit besides PR #1015.
For example, #1014 is also missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants