Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): add logic to paint free rows #105

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Conversation

malegreIndec
Copy link
Contributor

Description

Add a new variant and property to paint the free rows of the table component

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How to test

  1. List instructions for how to test
  2. Make sure it's detailed and includes the exact steps

@malegreIndec malegreIndec requested a review from arielerv February 5, 2024 13:28
@malegreIndec malegreIndec changed the title feat(table): add new variant and property in table component feat(table): add logic to paint free rows Feb 6, 2024
@maximilianoforlenza
Copy link
Member

maximilianoforlenza commented Feb 6, 2024

Seria conveniente que agregues un caso donde haya una fila vacia y le pases la prop paintFreeRowsColor dentro de storybook (https://github.com/indec-it/react-commons/blob/master/src/components/Table/Table.stories.js) para que se vea reflejado cuando yo corra el job de storybook aca https://indec-it.github.io/react-commons/?path=/story/components-table-table--basic&args=params.skip:0 quede reflejado como se ve dentro de la tabla cuando hay una fila vacia

src/theme/components/table.js Outdated Show resolved Hide resolved
src/components/Table/Table.js Outdated Show resolved Hide resolved
src/theme/components/table.js Outdated Show resolved Hide resolved
@maximilianoforlenza maximilianoforlenza merged commit 930cd78 into master Feb 6, 2024
2 checks passed
@maximilianoforlenza maximilianoforlenza deleted the feat/table branch February 6, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants