Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change login screen design #4

Open
wants to merge 2 commits into
base: mvvm/login
Choose a base branch
from
Open

Change login screen design #4

wants to merge 2 commits into from

Conversation

khadkarajesh
Copy link

  • Changed the login screen design
  • Added BaseActivity

@khadkarajesh khadkarajesh added the enhancement New feature or request label Jul 18, 2019
@khadkarajesh khadkarajesh added this to the 1.0 milestone Jul 18, 2019
@khadkarajesh khadkarajesh requested a review from iamsannyrai July 18, 2019 10:20
@khadkarajesh khadkarajesh self-assigned this Jul 18, 2019
iamsannyrai
iamsannyrai reviewed Jul 18, 2019
View reviewed changes
app/src/main/java/com/incwelltechnology/lms/base/BaseActivity.kt

abstract class BaseActivity<B : ViewDataBinding> : AppCompatActivity() {
lateinit var dataBinding: B
override fun onCreate(savedInstanceState: Bundle?) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we write all the required codes which we used to write within onCreate() function in the other activity which extends this base activity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamsannyrai iamsannyrai iamsannyrai left review comments

Assignees

@khadkarajesh khadkarajesh

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@khadkarajesh @iamsannyrai