-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set default layout for projects in cms #75
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If projects all use the same layout you can set that layout in the directory data file for src/collections/projects
rather than having to add a field in the CMS and specify it for every project. I think that would be the better approach here.
Deploying inclusive-standards with Cloudflare Pages
|
@@ -2,6 +2,7 @@ import { __, generatePermalink } from "eleventy-plugin-fluid"; | |||
|
|||
export default { | |||
eleventyComputed: { | |||
layout: "layouts/project", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually doesn't need to be computed so it can be moved outside the eleventyComputed
block. See here: https://www.11ty.dev/docs/data-js/
Default layout wasn't set in the CMS config file for project, so when a new project is created from the CMS, the project wasn't displayed properly. Also, fixed a small issue where card content wasn't stretched fully.