Rails5 Update #2
Conversation
|
@jlsookiki This is my personal fork of the main repository https://github.com/jashmenn/activeuuid, so you'd better open your PR on the original one. Also I think these fixes are covered in my PR jashmenn#85. But if there are anything I've missed out, would you start discussions on that thread instead? Thanks. |
|
@inbeom I can make a PR to the actual repo that's fine. I only made this into yours since I forked it off yours. This just does a slight refactor or yours to remove some final deprecations |
|
@jlsookiki I read jashmenn#86 so now I see that. I am really sorry I missed to notice the base branch of this PR is not Can we continue our discussion after I merge #1? I think we can maintain activeuuid before @jashmenn decides working on it again. |
|
@jlsookiki I've done some housekeeping works on this fork so we can start our discussion from now on. Can you open your PR against |
|
@inbeom sounds good. I'll open it up in a bit |
Removed the
alias_method_chains since that is being deprecated. Also forced a version of Rake to allow all tests to pass