feat: add the SLSA models for its v1.0 spec #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chizhg
force-pushed
the
slsa-v1
branch
3 times, most recently
from
8e9efdc
to
3c4619d
Compare
|
@Alos could you have a look at this when you have time? Thanks! |
|
Overall this looks good to me. @adityasaky would you like to approve this? |
adityasaky
reviewed
Mar 29, 2024
SantiagoTorres
approved these changes
Mar 29, 2024
Signed-off-by: Chi Zhang <[email protected]>
I have added the unit tests, please take a second look. Thanks! |
|
Friendly ping on this. @SantiagoTorres @adityasaky could you take a second look and merge the PR if it looks good to you? |
adityasaky
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
I think this is fine. @SantiagoTorres / @Alos could you confirm?
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BTW also fix the predicate type for SLSA v0.2 and related unit tests.