Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement system packages attestation for Debian and RPM backends #421

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fkautz
Copy link
Contributor

@fkautz fkautz commented Jan 27, 2025

Signed-off-by: Frederick F. Kautz IV [email protected]

@fkautz fkautz force-pushed the systempackages branch 2 times, most recently from b9565ac to d2c65ff Compare January 27, 2025 06:19
@fkautz
Copy link
Contributor Author

fkautz commented Jan 28, 2025

Will add a subject then we will be good for review and merge.

Copy link
Member

@colek42 colek42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good. I'd like to see some table tests to test the parsing functions, check for edge cases, and use of the logger rather than fmt.

// Attest implements attestation.Attestor.
func (a *Attestor) Attest(ctx *attestation.AttestationContext) error {
os, dist, version, err := a.backend.DetermineOSInfo()
fmt.Println(os)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the logger here? I have a console logger I am using to test this branch. #408

@fkautz fkautz force-pushed the systempackages branch 3 times, most recently from a4385e6 to 092a40c Compare January 29, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants