Support Witness attestation collections #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that at this moment, there are no rules enforced on attestation collections because their attribute checks are still up in the air. However, it can enforce materials / products. Next up is supporting attribute checks for non-materials / products data in a collection. cc @jkjell |
adityasaky
force-pushed
the
consolidation
branch
from
bc3f6ed
to
0620d38
Compare
adityasaky
requested review from
marcelamelara and
trishankatdatadog
as code owners
|
I'll wait for @jkjell to review |
adityasaky
force-pushed
the
consolidation
branch
from
0ed7108
to
9e04198
Compare
Signed-off-by: Aditya Sirish <[email protected]>
adityasaky
force-pushed
the
consolidation
branch
2 times, most recently
from
8ef2732
to
dca45a2
Compare
|
cc @ChaosInTheCRD as well |
This is a bit too big and the context is missing a fair bit. Could you explain it at the next meeting? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the schema for layouts a bit. I'll eventually break this up into separate commits.
It also adds initial support for attestation collections from Witness.