Adds collection items #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro-savage
commented
Oct 4, 2016
| @@ -19,6 +19,8 @@ | |||
| "dist:copy-static": "cp -r src/static dist/static", | |||
| "dist-static:clean": "rm -rf dist_static && mkdir dist_static", | |||
| "dist-static:copy-static": "cp -r src/static dist_static/static", | |||
| "lint": "eslint ./src/", | |||
There was a problem hiding this comment.
We can now lint things :)
| @@ -0,0 +1,41 @@ | |||
| import React from 'react' | |||
There was a problem hiding this comment.
Mixes Route and Redux. Not sure if this is best way to do it. But otherwise I would be creating a route that just has a container than then has the same stuff. Extra layer, didn't seem to be a good reason for it.
|
@nickmask Ready for code review :) You will need to do an |
nickmask
requested changes
Oct 4, 2016
| const DeepZoom = (props) => { | ||
| return ( | ||
| <div> | ||
| <iframe width="640" height="360" src={props.url} frameBorder="0" allowFullScreen /> |
There was a problem hiding this comment.
- Need to change width to 100%. Currently cuts off options with the fixed width.
- Full screen mode currently doesn't work. Looks like an issue with GigaPan, so unsure what we can do here. Full screen mode does work on the 3D models.
| const Model3d = (props) => { | ||
| return ( | ||
| <div> | ||
| <iframe width="640" height="480" src={props.url} frameBorder="0" allowFullScreen /> |
There was a problem hiding this comment.
Need to change width to 100%. Height is also a bit much for the iphone 4, but we can deal with that when we style.
This was referenced Oct 5, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: