Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imxrt1180 feature and pads #46

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

nilfit
Copy link
Contributor

@nilfit nilfit commented Oct 30, 2024

Derived from the 1189 CM33 SVD. The pad definitions are exactly the same in the CM7 SVD; confirmed by diffing the iomuxc output for the CM33- and CM7-based outputs.

This covers 175 of the 190 pins mentioned in the Pin Assignments table of chapter 13 External Signals and Pin Multiplexing. The 15 that are missing are the 10 GPIO_BBSM_* pins and a few others (POR_B, ONOFF, ...), none of which have alternate modes.

Copy link

@korken89 korken89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only small typo, else LGTM. Thoughts @mciantyre ?

src/imxrt1180/mod.rs Outdated Show resolved Hide resolved
src/imxrt1180/mod.rs Outdated Show resolved Hide resolved
Derived from the 1189 CM33 SVD. The pad definitions are exactly the same
in the CM7 SVD; confirmed by diffing the iomuxc output for the CM33-
and CM7-based outputs.
Copy link
Member

@mciantyre mciantyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed up the typos in my remote, in case you'd like to force push that commit into your branch.

Looks like a good start. I made sure we didn't have excessive number of GPIOs with offsets 0 or 1, like the defect that #44 fixed.

It looks like #28 applies to the 1180. I updated the issue title.

@nilfit nilfit force-pushed the rt1180 branch 2 times, most recently from 3382785 to 3b5624f Compare October 31, 2024 15:06
@mciantyre mciantyre merged commit 3b5624f into imxrt-rs:master Nov 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants