Fix embedded-hal version #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This crate uses eh02::blocking::i2c::Operation, which only exists for embedded-hal 0.2.6 and upwards. - This crate uses .complement() which only exists in bitflags 1.3 and upwards. - We use trailing commas, available in the 0.1.3 ral-registers release.
mciantyre
force-pushed
the
fix_embedded_hal_version
branch
from
2ae8762 to
4abef5b
Compare
mciantyre
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Thanks, looks good. There's a commit on main that uses the trailing comma support in the latest ral-registers release. I bumped the version during my rebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
embedded-halto0.2.6:This crate uses
eh02::blocking::i2c::Operation, which only exists forembedded-hal 0.2.6and upwardsbitflagsto1.3:This crate uses
.complement()which only exists inbitflags 1.3and upwardsral-registersto0.1.2:This crate uses newer features from
ral-registers 0.1.2