Update SIBYLL* #219
Open
Update SIBYLL* #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afedynitch
force-pushed
the
update_sibyll_star
branch
from
df64df3 to
9dc5c1f
Compare
There was a problem hiding this comment.
Copilot reviewed 96 out of 100 changed files in this pull request and generated no comments.
Files not reviewed (4)
- CMakeLists.txt: Language not supported
- default_models.cfg: Language not supported
- setup.cfg: Language not supported
- src/fortran/dpmjetIII-19.1: Language not supported
Comments suppressed due to low confidence (3)
tests/test_final_state.py:37
- Review whether excluding Sibyll23StarMixed from the skip condition is intentional. If legacy support is needed, consider including it.
if Model in [im.Sibyll23dStarMixed, im.Sibyll23eStarMixed]:
src/chromo/models/sibyll.py:425
- [nitpick] Consider explicitly setting a _library_name attribute in Sibyll23eStarMixed for consistency with similar classes.
class Sibyll23eStarMixed(Sibyll23eStarNoEnh):
README.md:75
- [nitpick] Clarify the naming in the README to better differentiate between updated SIBYLL-2.3 versions and legacy SIBYLL* entries.
| [SIBYLL* (based on 2.3d)](https://inspirehep.net/literature/2774307) | *hN, hA (A<=20)* | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update SIBYLL* based on SIBYLL-2.3d to the latest version (p04).