Heretics #249
Merged
Heretics #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* i got that dawg in me * dasasdsaddas * jhkhkjj * my lazy ass is not doing the rest * finally. * finally. * jesus christ 1 * help me * jesus christ 2 * UAAAAWHGHHGG BUABHAUBHAUBHHGH * jesus christ 3 * sdfjsdkghjdfkljbhsfuobd * 1984 * ash lore update * THE CURSE OF 220 * ultra violencce * fart * fdgfdgbfdbf * fgbdfgndfgn * it's raw propheting time * blbkblbkglbgkbgbgbgdfbfgbbb AAAAAAAAAAAAAAAAAAAAAAAAA * fdbfsgbybdf * bkbgkblkgbgbngfkb * void path part 1 * REAL!!!!!! * it is working * ok looks good to me * random influence spawn * hey shitass, wanna see me bypass yaml linter? * RAAAAAAAAAAGH * dghgdfbsfdgbsdf * dfvsfvavsd * help * help * bbnvbnvmvbnmvbnmvbn * guiedbook * fhfdsghfgdhdfgh * AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA * please * fucking die * vlkblvkbbgjhjfbhnbkvbnf A * i am malding * 6666 lines * FUCK * GOD SAVE MY SOUL!! * revert store shitassery * dfvdfgdf * Reapply "Uplink discounts (impstation#580)" This reverts commit 55540db. * more uplink shittery revert * FUCK * based * dvsfv * dghfgghfgh * blnkbnbknlbnklb ** finally.
…r now) (space-wizards#26297) * feat: space-wizards#26107 uplink discounts for traitors and nukies * refactor: space-wizards#26107 extracted discount label from price of StoreListingControl * refactor: minor renaming * refactor: parametrized adding discounts to uplink store * fix: space-wizards#26107 prevent exception on empty discountOptions * feat: uplink now have 'Discounted' category which contains all discounted items on this session. * after merge fixups * rename discount categories according to common sense * refactor: DiscountOptions is now optional (nullable) on ListingData * add nullability check ignore for already checked listingData.DiscountOptions * fix after merge store menu ui * remove unused using * final fix after merge conflicts * [refactor]: space-wizards#26107 fix variables naming in UplinkSystem * fix: space-wizards#26107 fix after merge * refactor: space-wizards#26107 now supports discountDownUntil on ListingItem, instead of % of discount * feat: space-wizards#26107 support multiple currency discount in store on side of discount message label * refactor: space-wizards#26107 extracted discounts initialization to separate system. StoreDiscountData are spread as array and not list now * refactor: space-wizards#26107 move more code from storesystem to StoreDiscountComponent * refactor: space-wizards#26107 separated StoreSystem and StoreDiscountSystem using events * fix: space-wizards#26107 placed not-nullable variable initialization in ListingData for tests * refactor: space-wizards#26107 minor renaming, xml-docs * fix: space-wizards#26107 changed most of discounts to be down to half price for balance purposes * ids used in with discounts are now ProtoIds, dicountCategories are now prototypes, code with weights simplified * decoupled storesystem and store discount system * xml-docs * refactor: space-wizards#26107 xml-doc for StoreDiscountSystem * is now a thing (tmp) * fix: compilation errors + StoreDiscountData.DiscountCategoryId * refactor: rename ListingDataWithCostModifiers, fix all cost related code, enpittyfy performance, uglify uplink_catalog * refactor: removed unused code, more StoreDiscountSystem docs, simplify code * refactor: moved discount category logic to respective system, now creating ListingData c-tor clones all mutable fields as expected * refactor: rename back (its not prototype) * refactor: move ListingItemsInitializingEvent to file with handling logic * refactor: comments for StoreBuyFinishedEvent handling, more logging * refactor: moved StoreInitializedEvent, xml-doc * refactor: simplify StoreDiscountSystem code (reduce nesting) + xml-doc * refactor: restore old listing data cost field name * refactor: fix linter in uplink_catalog.yml * refactor: xml-doc for ListingDataWithCostModifiers * refactor: limit usage of ListingData in favour of ListingDataWithCostModifiers * refactor: purged linq, removed custom datafield names, minor cleanup * refactor: removed double-allocation on getting available listings * refactor: StoreSystem.OnBuyRequest now uses component.FullListingsCatalog as reference point (as it was in original code) * fix: minor discount categories on uplink items changes following design overview * refactor: StoreBuyListingMessage now uses protoId and not whole object * refactor: store refund and discount integration test, RefreshAllListings now translates previous cost modifiers to refreshed list, if state previous to refresh had any listing items --------- Co-authored-by: pa.pecherskij <[email protected]>
|
all checks passed 👍 i cant wait to tear my hair out bugfixing 👍 heretic real 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Gates of Mansus open up to your mind.
Forgotten, devoured, gutted. Humanity has forgotten the eldritch forces of decay, but the mansus veil has weakened. We will make them taste fear again...
ports heretics from goobstation (Goob-Station/Goob-Station#563, Goob-Station/Goob-Station#601, Goob-Station/Goob-Station#615, Goob-Station/Goob-Station#628). will need playtesting, refinement, and adjustments, but the framework is here. gain knowledge and achieve your final ascension.
known issues
🆑