-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
centcomm role tweaks #1423
centcomm role tweaks #1423
Conversation
theres something wrong with jobs.yml but i cannot for the life of me figure out what |
Resources/Textures/_Impstation/Interface/Misc/job_icons.rsi/Admin.png
Outdated
Show resolved
Hide resolved
the NT icon is updated to the proper shade of green but for whatever reason all the other jobs wont read the new icons, just reusing the NT one. im going to scream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to checkout this and test for real later but heres your mandated anal retention review
Resources/Textures/_Impstation/Interface/Misc/job_icons.rsi/meta.json
Outdated
Show resolved
Hide resolved
the changelog in the description needs amending, it needs to be |
…me of the IDs having weird layers)
Resources/Prototypes/Entities/Objects/Misc/identification_cards.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approaching the finish line here
state: Nanotrasen | ||
jobName: job-name-centcomoff | ||
# - type: jobIcon (moved to imp) | ||
# parent: JobIcon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct me if im wrong, but it looks like the only ones of these that got moved out of job.yml are JobIconNanotrasen and JobIconAdmin. which should not have been moved out of this namespace, they should stay here with the updated sprites
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i realize my ass has been contradictory bc i didnt totally understand what you were attempting to do here so ill just give actual instructions
- delete all these commented out jobIcons. they either were never in this file to begin with or should have never left.
- move the altered JobIconNanotrasen and JobIconAdmin back into this file
- also those are going to need imp comments since theyre altering an upstream prototype. the way you have been annotating all other upstream edits has been fantastic in the rest of this pr so keep it up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll go ahead and approve the other changes so you arent waiting for my review, once hives changes have been made we shoooould (?) be good to merge. really good work on this, thanks for being so patient with requested changes lmao
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WE DID IT!!!!!!!!!!!
Changelog
🆑