Firearms Upkeep #1421
Merged
Firearms Upkeep #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding #imp to the changes I made to the vanilla firearms, additions to the secfab, and research items. Included is a description change for the Captain's Laser, as well as a fix for the Mosin's speedloader to use the correct ammunition.
hivehum
requested changes
Jan 19, 2025
Resources/Prototypes/Entities/Objects/Weapons/Guns/Battery/battery_guns.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/Entities/Objects/Weapons/Guns/Revolvers/revolvers.yml
Outdated
Show resolved
Hide resolved
kipdotnet
approved these changes
Jan 19, 2025
I moved the #imp comments I wasn't confident wouldn't show up in the examine description back to the description and tested. None of the vanilla weapons have #imp in their descriptions and the speedloader fix works.
Wizden doesn't proofread and I'm fixing consistency with weapon name capitalizations. Probably not all of them but a lot of them are done here. Also fixing my own weapon name capitalizations. The fake Golden Zipper's name being all lowercase still is intentional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing fancy here. Adding #imp to the changes I made to the vanilla firearms/magazines/ammunition, as well as any additions I've made to default arsenal research items and lathe recipe lists. Included is a description change for the Captain's Laser, as well as a fix for the Mosin's speedloader to use the correct ammunition.
🆑