Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doll joint tattoos #1234

Merged
merged 2 commits into from
Jan 6, 2025
Merged

doll joint tattoos #1234

merged 2 commits into from
Jan 6, 2025

Conversation

Sha-Seng
Copy link

@Sha-Seng Sha-Seng commented Jan 5, 2025

heey just some tattoos

preview

🆑

  • add: Doll Joint arm and leg tattoos, and 'Cut Here' chest tattoo for humans, dwarves, spiders, slimes, and lizards

heey just some tattoos
@@ -1,2 +1,17 @@
marking-TattooNanotrasenChest-tattoo_nanotrasen_chest = Chest Tattoo (Nanotrasen)
marking-TattooNanotrasenChest = Chest Tattoo (Nanotrasen)

marking-TattooDollLeftArm-tattoo_doll_l_arm = Left Arm Tattoo (Doll Joints)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as of #1204 im trying to establish standards for the names of markings. you can check that pr for more examples but generally it's

"Descriptive name (location only if necessary)" so this highlighted line would be "Doll Joint Tattoo (Left Arm)" but line 16/17 would just be "'Cut Here' Tattoo"

@hivehum
Copy link

hivehum commented Jan 5, 2025

this is much more subjective and not regarding implementation standards but i dont personally feel like the doll joints tattoos really accomplish being doll joints? i'm not certain you have the pixel real estate to pull off that kind of design. they kind of just look like stripes atm

additionally i think the 'cut here' tattoo is fitting the same niche as the existing torso incision, star scar, and top surgery markings, which can easily be recolored to resemble tattoos:

SS14 Loader_7I0ccF9Uqm SS14 Loader_80vqeuJ4Om SS14 Loader_0Rcwtl1ChE

edit: also using TattooColoring is making them default to being completely invisible due to the fact that the textures you are using are #FFFFFF white with zero shading
SS14 Loader_WvI8ehBsuY
this is with all four doll joints markings added but no colors altered

@Sha-Seng
Copy link
Author

Sha-Seng commented Jan 5, 2025

Doll joints was the intent while making it, but let's be honest the tattoos in this game can't be anything very clearly, so you just name them something to give it a personality. They're arm stripes, that's all. We don't have arm stripes like this.

As for the incision scar, I actually tried to use that first, but I found that because the base sprite was made a pinkish color and not white, you can't make it a full range of colors. If you make it white, it'll be pink. Tattoos aren't scars and should be able to be blue and green and so on.

As for the colors chosen, I color sampled the other tattoos from upstream. That's intentional so you can have brightly colored tattoos if you want. Three types of white make up existing tattoos, so I'd argue that's not an issue but rather the intent.

I'll look into the transparency thing, but first I have to confirm that's not an issue with the other tattoos (Silverburgh and Campbelle for instance) because all I did was copy their implementation.

@SixValentine
Copy link

Style wise I do wonder if it overlaps with campbelles over the arms look. A to be seen thing. I'd almost want to see a doll joints left and right leg as well like Campbell and silverburgh has I think it'd go hard. The knee joints would probably read better than the elbows do. The shoulders seems pretty clear though

@Sha-Seng
Copy link
Author

Sha-Seng commented Jan 5, 2025

Style wise I do wonder if it overlaps with campbelles over the arms look.

Here's Doll Joints on the right arm and Campbell on the left arm for comparison. I think it's sufficiently different in that it reaches the edges of the sprite and extends all the way down to the fingers, but that's just me.

Also shown is all markings in pure white to display why a chest scar isn't accomplishing the same look as a chest tattoo, and that my color selection was correct and intentional, with slight shading.

image

And yeah it would be easy to add leg markings to this. I'd love some leg stripes.

@Sha-Seng
Copy link
Author

Sha-Seng commented Jan 5, 2025

edit: also using TattooColoring is making them default to being completely invisible due to the fact that the textures you are using are #FFFFFF white with zero shading

Pretty sure this is a system problem and would apply to any tattoos. That's outside the scope of a PR adding a cosmetic choice.

image

@hivehum
Copy link

hivehum commented Jan 5, 2025

i am not asking you to change how TattooColoring works mechanically, i am asking you to consider how your marking looks when used ingame

@Sha-Seng
Copy link
Author

Sha-Seng commented Jan 5, 2025

I have, and I think they look sick.

image

When you said you couldn't see them, I presume that's because you selected the exact skin color that TattooColoring just happens to overlap with - and that's only an issue before you touch the sliders. Frankly it's so unlikely to happen by mistake that I'm not worried at all. Did you do that on purpose to demonstrate an issue? In any case, that would apply to all tattoos.

image

I'll add leg versions to the set later today.

@Pinkbat5
Copy link

Pinkbat5 commented Jan 5, 2025

It's nice to see some straightforward arm stripes, sometimes it's hard to tell what the upstream tattoos are intended to be. It's easy to parse these at the small resolution we're working with. It would be sick to see these on a mime.
I wonder if these would look good on spiders? They have fur patterns, not tattoos, but they lend themselves well to stripes.

@Sha-Seng
Copy link
Author

Sha-Seng commented Jan 5, 2025

I wonder if these would look good on spiders?

Done! Here's a spider with the whole set.

image

I added slimes and reptilians too - although reptilians don't have the foot options because for some reason their displacement map messes them up.

Naming conventions updated as well.

@Darkmajia Darkmajia requested a review from hivehum January 6, 2025 23:12
@hivehum hivehum merged commit 01e4b3e into impstation:master Jan 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants