-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doll joint tattoos #1234
doll joint tattoos #1234
Conversation
heey just some tattoos
@@ -1,2 +1,17 @@ | |||
marking-TattooNanotrasenChest-tattoo_nanotrasen_chest = Chest Tattoo (Nanotrasen) | |||
marking-TattooNanotrasenChest = Chest Tattoo (Nanotrasen) | |||
|
|||
marking-TattooDollLeftArm-tattoo_doll_l_arm = Left Arm Tattoo (Doll Joints) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as of #1204 im trying to establish standards for the names of markings. you can check that pr for more examples but generally it's
"Descriptive name (location only if necessary)" so this highlighted line would be "Doll Joint Tattoo (Left Arm)" but line 16/17 would just be "'Cut Here' Tattoo"
Doll joints was the intent while making it, but let's be honest the tattoos in this game can't be anything very clearly, so you just name them something to give it a personality. They're arm stripes, that's all. We don't have arm stripes like this. As for the incision scar, I actually tried to use that first, but I found that because the base sprite was made a pinkish color and not white, you can't make it a full range of colors. If you make it white, it'll be pink. Tattoos aren't scars and should be able to be blue and green and so on. As for the colors chosen, I color sampled the other tattoos from upstream. That's intentional so you can have brightly colored tattoos if you want. Three types of white make up existing tattoos, so I'd argue that's not an issue but rather the intent. I'll look into the transparency thing, but first I have to confirm that's not an issue with the other tattoos (Silverburgh and Campbelle for instance) because all I did was copy their implementation. |
Style wise I do wonder if it overlaps with campbelles over the arms look. A to be seen thing. I'd almost want to see a doll joints left and right leg as well like Campbell and silverburgh has I think it'd go hard. The knee joints would probably read better than the elbows do. The shoulders seems pretty clear though |
Here's Doll Joints on the right arm and Campbell on the left arm for comparison. I think it's sufficiently different in that it reaches the edges of the sprite and extends all the way down to the fingers, but that's just me. Also shown is all markings in pure white to display why a chest scar isn't accomplishing the same look as a chest tattoo, and that my color selection was correct and intentional, with slight shading. And yeah it would be easy to add leg markings to this. I'd love some leg stripes. |
i am not asking you to change how TattooColoring works mechanically, i am asking you to consider how your marking looks when used ingame |
I have, and I think they look sick. When you said you couldn't see them, I presume that's because you selected the exact skin color that TattooColoring just happens to overlap with - and that's only an issue before you touch the sliders. Frankly it's so unlikely to happen by mistake that I'm not worried at all. Did you do that on purpose to demonstrate an issue? In any case, that would apply to all tattoos. I'll add leg versions to the set later today. |
It's nice to see some straightforward arm stripes, sometimes it's hard to tell what the upstream tattoos are intended to be. It's easy to parse these at the small resolution we're working with. It would be sick to see these on a mime. |
heey just some tattoos
🆑