Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suits Suits Suits! #1223

Merged
merged 5 commits into from
Jan 4, 2025
Merged

Suits Suits Suits! #1223

merged 5 commits into from
Jan 4, 2025

Conversation

MintyTheBinty
Copy link

A fresh shipment of linens has been sent to the station, and its YOUR job to put them on!

NewSuitsIcons

NewSuitsEquiped

Created 10 new suit and blazer styled outfits after the lawyer suit included in the uplink sniper bundle fell so flat to its Hitman comparison. Each suits will be available for select job loadouts, with all but one (the senior bartender suit) also being available in vendors across the station. The suits and their loadout availability are as follows (going from let to right, top to down of the shared images):

  • BROS Blazer and Jeans: Reporter and hacked AutoDrobe
  • Detectives Suit: Detective and DetDrobe
  • Senior Bartender Suit: Bartender/Service Worker (52 hour Bartender requirement, like the PDA)
  • Brown Suit: Librarian and CuraDrobe
  • Funeral Suit: Chaplain and PietyDrobe
  • Nightclub Suit: Bartender/Service Worker and BarDrobe
  • Contract Killer Suit: Uplink Sniper Bundle and hacked AutoDrobe
  • Miami Vice Suit: Detective and DetDrobe
  • Mr. Space Wide Suit: Musician and AutoDrobe
  • Cream Suit: Lawyer and LawDrobe

🆑 MintyTheBinty

  • add: Added 10 new suits and made them available in drobes and loadouts!

@kipdotnet
Copy link

Fuck yes. These look awesome

@Darkmajia
Copy link

Content Client_u3S6plkjlp
holy fuck ship it

hivehum
hivehum previously approved these changes Jan 4, 2025
Copy link

@hivehum hivehum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor changes. these fuck insanely, great work

Resources/Prototypes/Catalog/Fills/Items/briefcases.yml Outdated Show resolved Hide resolved
@@ -35,6 +35,32 @@
equipment:
jumpsuit: ClothingUniformJumpsuitBartenderPurple

- type: loadout
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all these loadout prototypes should go into our own file structure

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, would it just be the job yml's that need to be in the impstation structure or does the loadout_groups.yml have to get moved too? I can remove em from the ymls in the main structure and move em on over there.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anything that is a new prototype should be in our file structure, so the loadout_groups edits are fine (because you are changing an existing prototype) but all the loadouts you added to these job ymls should be moved

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha gotcha, just got the changes committed now. Anything else I should fiddle with before final approval?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you deleted the meta.json of jumpskirt/hitmansuit.rsi, which is causing issues

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added back in now, hit ctrl z one to many times....

@hivehum hivehum dismissed their stale review January 4, 2025 02:05

i hit approve on accident

@hivehum
Copy link

hivehum commented Jan 4, 2025

LGTM! great work :)

@hivehum hivehum merged commit fd4aa90 into impstation:master Jan 4, 2025
5 checks passed
@MintyTheBinty MintyTheBinty deleted the fancy-suits branch January 4, 2025 02:26
@MintyTheBinty MintyTheBinty restored the fancy-suits branch January 4, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants