Fix: Donation confirmation email - donation description #7602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| foreach ( $options as $option ) { | ||
| if (isset($option['_give_amount'], $option['_give_text'])) { | ||
| if (Money::of($option['_give_amount'], $currency )->getMinorAmount() == $donation->amount->getAmount()) { | ||
| return sprintf('%s %s %s', $form_title, $args['separator'], $option['_give_text']); |
There was a problem hiding this comment.
Should we be returning early here or overwriting the variables used by the filter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the issue with the wrong donation description in the confirmation email. The problem affects V3 forms only because there is a missing meta key (_give_payment_price_id) which is used to determine the donation level. The issue is resolved by checking if the donation form is a V3 form and then comparing the donation amount with the donation level amount set in form settings.
Affects
Donation receipt email
Testing Instructions
Pre-review Checklist
@unreleasedtags included in DocBlocks