Remove the apt-get retry loop in provision_dep.sh
#781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedataking
requested changes
Jan 15, 2023
It used to be there as the script ran in CI, but it no longer is, so we don't need to retry anymore. See #770 (comment).
kkysen
force-pushed
the
kkysen/remove-provision-deb-retry-loop
branch
from
9212b60 to
d0fda48
Compare
Oops, I misunderstood. It's fixed now. |
|
I don't see the button to approve this PR but it looks great now, thanks! Going to merge it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
apt-getretry loop inprovision_dep.sh.It used to be there as the script ran in CI, but it no longer is, so we don't need to retry anymore.
See #770 (comment).