Skip to content

Add a c2rust-analyze test for lighttpd-minimal #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2023
Merged

Add a c2rust-analyze test for lighttpd-minimal #772

merged 1 commit into from
Jan 9, 2023

Conversation

kkysen
Copy link
Contributor

@kkysen kkysen commented Jan 9, 2023 •
edited
Loading

This adds a c2rust-analyze test for lighttpd-minimal that just checks that c2rust-analyze runs without error on it.

@kkysen
Added a c2rust-analyze test for lighttpd-minimal.
19eec81 
It just checks that `c2rust-analyze` runs without error on it.
@kkysen kkysen requested a review from aneksteind January 9, 2023 08:58
@kkysen
Copy link
Contributor Author

kkysen commented Jan 9, 2023 •
edited
Loading

Turns out the #[feature(rustc_private)]s from #732 were used. They're needed by c2rust-analyze since it runs rustc directly, not through cargo, and extern crate libc requires #[feature(rustc_private)] when used directly from rustc. I'll revert this, or maybe just use std::ffi instead. Clearly having these tests in CI is important.

This was referenced Jan 9, 2023
Merged
Merged
aneksteind added a commit that referenced this pull request Jan 9, 2023
@aneksteind
revert changes introduced in #732 (#773)
a4b950f 
Reverts #732. `#![feature(rustc_private)]` is necessary to execute
`c2rust-analyze`, as it utilizes `rustc` directly (see comment
[here](#772 (comment))).
This restores functionality in preparation for #772.
@aneksteind aneksteind merged commit 0c6d598 into master Jan 9, 2023
@aneksteind aneksteind deleted the kkysen/analyze-lighttpd-test branch January 9, 2023 17:15
@kkysen
Copy link
Contributor Author

kkysen commented Jan 9, 2023

Note that this still isn't being tested in CI until #771 lands, so we want to land that soon. We can enable this in CI without #771, but it's more work than merging #770 and #771. Just make just to test locally until that lands. @aneksteind

@aneksteind
Copy link
Contributor

Understood, will try to expedite the docker image changes needed shortly after #770 lands

@kkysen kkysen mentioned this pull request Feb 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aneksteind aneksteind Awaiting requested review from aneksteind

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test c2rust-analyze on lighttpd-minimal
2 participants
@kkysen @aneksteind