Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new MR cards and some updates to other tables #581

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

nia-potato
Copy link

🚨 Proposed changes

Please review the guidelines for contributing to this repository.

Resolves #476
first of all i am very new to TS hence some of the code may look weird.

adds

  • EntityGitlabMergeRequestsAssignedToMeCard
  • EntityGitlabMergeRequestsAssignedToReviewCard

(Both card above shows only three MRs by default, to follow the same standards of the default backstage home cards)

  • EntityGitlabMergeRequestsForTeamBoard
    • extracts jira tickets from MR title and generates a icon on the bottom right for you to click and will redirect you to your jira ticket
    • will show Draft and gitlab labels as independent labels
    • will also show the pipeline status
    • will catagorize your MRs for your gitlab group in to three different categories for easy viewing.

edits

  • MRTable ( made it more compact, and added a button dropdown to filter by MR status. Open is the default status)
  • PipelineTable ( made it more compact, and changed the full URL link as a hyperlink to the PipelineID)

now the whole page can be visible in a tab without scrolling down.

PICs
Group View MR Board
Screenshot 2024-09-20 at 14 17 52

Original Entity Page

HomePage MR assigned and requested review cards
Screenshot 2024-09-20 at 13 58 29

⚙️ Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Refactor

@antoniomuso antoniomuso changed the base branch from main to next September 26, 2024 08:47
@antoniomuso
Copy link
Contributor

Hi @nia-potato, thanks for the PR, I don't understand well. Are there two cards for the homepage? Could you let me know if you added another section? Because I don't understand where each card is shown. Could you explain it better?


const MergeRequestsAssignedToMeCard = () => {
const theme = useTheme();
const gitlab_instance = 'gitlab.${internal-gitlab-domain}.com';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this... it should be taken by the Backstage entity

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gitlab MR request by Owner card
2 participants