refactor: migrate activity repo to kysely #15203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jason Rasmussen <[email protected]>
jrasm91
approved these changes
Jan 9, 2025
mertalev
reviewed
Jan 9, 2025
| const { count } = await this.db | ||
| .selectFrom('activity') | ||
| .select((eb) => eb.fn.countAll().as('count')) | ||
| .leftJoin('users', 'users.id', 'activity.userId') |
There was a problem hiding this comment.
The user relation should be an inner join.
| .where('activity.albumId', '=', albumId) | ||
| .where('activity.isLiked', '=', false) | ||
| .where('users.deletedAt', 'is', null) | ||
| .where('assets.deletedAt', 'is', null) |
There was a problem hiding this comment.
If you do this check, then wouldn't the left join effectively work like an inner join because it requires an asset with a null deletedAt to exist?
There was a problem hiding this comment.
You might be right. You are saying you could rewrite this as an inner join with the condition of joining on id and where deleted at is null?
aminesebastian
pushed a commit
to suburban-digital/immich-sd
that referenced
this pull request
Jan 12, 2025
Co-authored-by: Jason Rasmussen <[email protected]>
yosit
pushed a commit
to yosit/immich
that referenced
this pull request
Jan 13, 2025
Co-authored-by: Jason Rasmussen <[email protected]>
arctic-foxtato
pushed a commit
to arctic-foxtato/immich
that referenced
this pull request
Jan 14, 2025
Co-authored-by: Jason Rasmussen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.