fix(mobile): set custom headers on external url (#14707) #14708
Merged
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when setting up a external server for automatic URL switching ensure all access token AND custom headers are used for the server validaton request
alextran1502
approved these changes
Dec 15, 2024
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes it so that when entering an External Network endpoint for Automatic URL switching that it uses all the headers from
ApiService.getRequestHeaders()instead of hard-coding onlyx-immich-user-tokenThis way the server test will include both
x-immich-user-tokenAND any custom proxy headers that are configured, sinceApiService.getRequestHeaders()returns a map containing all of these.This is necessary if the external network endpoint you are trying to configure requires these custom proxy headers (such as if you are using Cloudflare with Service Auth headers)
Without this fix, it's impossible to configure such a server as an external endpoint since the call to
$url/users/mewill fail (due to missing custom headers) and the endpoint won't be added.Close #14707