Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(album): album view sort order #14648

Merged
merged 7 commits into from
Dec 16, 2024
Merged

feat(album): album view sort order #14648

merged 7 commits into from
Dec 16, 2024

Conversation

alextran1502
Copy link
Contributor

@alextran1502 alextran1502 commented Dec 11, 2024

This PR adds a button to toggle the album sort order on the mobile app.

Screen.Recording.2024-12-11.at.10.22.22.mov

@mertalev
Copy link
Contributor

Can you make the title etc. not flicker when the sort order changes?

Also, I think we should do another patch release without features for the live photo issue before merging features.

@alextran1502
Copy link
Contributor Author

alextran1502 commented Dec 11, 2024

Yeah we can have this feature in the next release. Fixing the flicker will require refactoring the whole page. Since the data of the page depends on the album provider, which is watching the database changes to the album record and triggering the whole page rebuild

@mertalev
Copy link
Contributor

Okay, well I think it should be refactored first then because it looks a bit janky when you toggle.

@alextran1502
Copy link
Contributor Author

@mertalev I think refactoring the page is outside the scope of this PR. Also I will need to discuss with you how we should restructure that fix since the whole page depends on that one provider, and if any property changes, it rerenders the page

* refactor album page

* update lint rule

* const record

* fix: updating sort order when pull to refresh

---------

Co-authored-by: Alex <[email protected]>
@alextran1502 alextran1502 enabled auto-merge (squash) December 16, 2024 15:59
@alextran1502 alextran1502 merged commit 9503bf4 into main Dec 16, 2024
36 checks passed
@alextran1502 alextran1502 deleted the feat/sort-album branch December 16, 2024 16:11
yosit pushed a commit to yosit/immich that referenced this pull request Dec 20, 2024
* feat(mobile): album view sort order

* feat: add error message

* refactor(mobile): album page (immich-app#14659)

* refactor album page

* update lint rule

* const record

* fix: updating sort order when pull to refresh

---------

Co-authored-by: Alex <[email protected]>

* Move sort toggle button to bottom sheet menu

* chore: revert multiselectgrid loading status

* chore: revert multiselectgrid loading status

---------

Co-authored-by: Mert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants