-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(album): album view sort order #14648
Conversation
Can you make the title etc. not flicker when the sort order changes? Also, I think we should do another patch release without features for the live photo issue before merging features. |
Yeah we can have this feature in the next release. Fixing the flicker will require refactoring the whole page. Since the data of the page depends on the album provider, which is watching the database changes to the album record and triggering the whole page rebuild |
Okay, well I think it should be refactored first then because it looks a bit janky when you toggle. |
@mertalev I think refactoring the page is outside the scope of this PR. Also I will need to discuss with you how we should restructure that fix since the whole page depends on that one provider, and if any property changes, it rerenders the page |
* refactor album page * update lint rule * const record * fix: updating sort order when pull to refresh --------- Co-authored-by: Alex <[email protected]>
* feat(mobile): album view sort order * feat: add error message * refactor(mobile): album page (immich-app#14659) * refactor album page * update lint rule * const record * fix: updating sort order when pull to refresh --------- Co-authored-by: Alex <[email protected]> * Move sort toggle button to bottom sheet menu * chore: revert multiselectgrid loading status * chore: revert multiselectgrid loading status --------- Co-authored-by: Mert <[email protected]>
This PR adds a button to toggle the album sort order on the mobile app.
Screen.Recording.2024-12-11.at.10.22.22.mov