feat(server): Merge Faces sorted by Similarity #14635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldietzler
approved these changes
Dec 11, 2024
|
I pushed a change that fixed the open-api test. I also ran it on a copy of my personal instance which has around 100k pictures and 5k people detected and I didn't see a noticeable difference in performance. Server specs: i7-12700k with 64 gb of ram. |
mertalev
reviewed
Dec 11, 2024
mertalev
approved these changes
Dec 12, 2024
|
Thanks for the PR! LGTM |
Lukasdotcom
force-pushed
the
merge
branch
2 times, most recently
from
e2f5802 to
9af6cd4
Compare
|
why similarity? I just merge an unnamed face into a named face not into a similarity face |
yosit
pushed a commit
to yosit/immich
that referenced
this pull request
Dec 20, 2024
* Merge Faces sorted by Similarity * Adds face sorting to the side panel face merger * run make open-api * Make it one query * Only have the single order by when sorting by closest face
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new optional parameter on the
/api/peopleroute allows clients to specify sorting order by similarity to a person. This sorting is used on the merge page to organize photos based on similarity.Implements: #4347