Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): Revert "fix(server): copy video projection metadata for 360 videos (#12376)" #13611

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

mertalev
Copy link
Contributor

@mertalev mertalev commented Oct 20, 2024

This reverts commit aa0097b.

Description

This flag is causing DOVI sidedata to persist in transcoded videos, causing playback issues on clients. There might be a way to persist spherical metadata while still stripping DOVI metadata in the future, but for now this is causing too many issues.

https://github.com/jellyfin/jellyfin-ffmpeg/blob/845992ead16fe912283fa577a211e4612052dc57/libavformat/movenc.c#L2542

Fixes #13479

How Has This Been Tested?

Tested that DOVI sidedata doesn't appear when transcoding with this flag removed.

Verified

This commit was signed with the committer’s verified signature.
mertalev Mert
…12376)"

This reverts commit aa0097b.
@mertalev mertalev changed the title Revert "fix(server): copy video projection metadata for 360 videos (#12376)" fix(server): Revert "fix(server): copy video projection metadata for 360 videos (#12376)" Oct 20, 2024
@alextran1502
Copy link
Contributor

Thanks for the fix. Confirmed that the video can now be played on Android

@alextran1502 alextran1502 merged commit 62e55f3 into main Oct 20, 2024
37 of 39 checks passed
@alextran1502 alextran1502 deleted the fix/server-dovi-sidedata branch October 20, 2024 15:15
yosit pushed a commit to yosit/immich that referenced this pull request Oct 24, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…360 videos (immich-app#12376)" (immich-app#13611)

Revert "fix(server): copy video projection metadata for 360 videos (immich-app#12376)"

This reverts commit aa0097b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Immich IOS app unable to stream video/live photos
4 participants