fix(web): reset select all button state on escape press #13600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldietzler
approved these changes
Oct 19, 2024
3 tasks
alextran1502
approved these changes
Oct 20, 2024
yosit
pushed a commit
to yosit/immich
that referenced
this pull request
Oct 24, 2024
…3600) * factor out cancel multiselect state logic to utils * use cancel multiselct helper in album page * use cancel multiselct helper in album-viewer component * use cancel multiselct helper in asset-grid component * remove unused to fix lint
This was referenced Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should resolve #13481 by setting isSelectingAllAssets when escape is pressed.
The change is extracting the logic from SelectAllAssets component into a helper and calling them in the album page as well as some other components I thought was suitable as well.