Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): explicitly use svt-av1 encoder #13389

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevincox
Copy link

@kevincox kevincox commented Oct 12, 2024

SVT-AV1 is much, much faster than the reference libaom encoder. In most real-world cases libaom is too slow to be practical, often struggling to achieve 0.1fps for 1080p content.

I suspect this is what was intended in f1ca179 when AV1 support was originally added as it sets the -svtav1-params flag which is ignored unless using the SVT-AV1 encoder. Furthermore there is lots of discussion about SVT-AV1 in the PR thread.

@kevincox
Copy link
Author

cc @n00mkrad as the original author to make sure I didn't miss something for why av1 was used.

cc @mertalev as a reviewer.

@mertalev
Copy link
Contributor

The FFmpeg build we use actually doesn't have libaom, so av1 uses SVT-AV1. It's good to be more explicit, though, especially for non-Docker installations.

@mertalev mertalev changed the title Use STV-AV1 encoder for AV1. chore(server): explicitly use svt-av1 encoder Oct 12, 2024
@mertalev
Copy link
Contributor

Running npm run format:fix should fix the failing check.

@martabal
Copy link
Member

@mertalev do we need to add the svt-av1 package to the base image, or is it included by default with the jellyfin-ffmpeg package ?

@mertalev
Copy link
Contributor

@mertalev do we need to add the svt-av1 package to the base image, or is it included by default with the jellyfin-ffmpeg package ?

It comes with jellyfin-ffmpeg, so no change is needed.

@martabal
Copy link
Member

It comes with jellyfin-ffmpeg, so no change is needed.

Nice

STV-AV1 is much, much faster than the reference libaom encoder. In most real-world cases libaom is too slow to be practical, often struggling to achieve 0.1fps for 1080p content.

I suspect this is what was intended in f1ca179 when AV1 support was originally added as it sets the `-svtav1-params` flag which is ignored unless using the STV-AV1 encoder. Furthermore there is lots of discussion about STV-AV1 in the PR thread.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants