-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
func: added should delete orginal after crop functionality #13279
base: main
Are you sure you want to change the base?
func: added should delete orginal after crop functionality #13279
Conversation
@mertalev Please add someone to review |
The linked issue doesn't seem related to this PR. Also, the edited image is lossy and loses some qualities of the image, like HDR. I think we should make that more robust before suggesting the user to delete the original. |
The cropping functionality is acting the same as previously, as I have not changed anything regarding the cropping functionality. I have just added the "delete the original" functionality after the cropping is done. For, cropping image quality functionality, you can create a new bug card, and I can start working on it. Also this functionality has nothing to do, within cropping functionality, so this just acts as a adds on as a functionality over the cropping functionality. |
You haven't changed it, sure. But the premise of the feature is that the user can effectively replace the original with the edited version. I don't think we should suggest this until the edited image has the same quality as the original. |
Ok, understood. I hope we can merge this after the crop image quality fix, as you mentioned. So, I have updated the code, where the image quality is maintained now after cropping. |
Any update on this @Clement83 |
Hi @yashrajjain726, just to clarify, I'm just an Immich enthusiast, not a contributor. I noticed a typo and left a comment to help. By the way, it's all good for me :) |
Great @Clement83 , As it was assigned to you, I thought you would be reviewer. |
Fixed #11800