Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.106.1 #99

Merged
merged 6 commits into from
Jun 11, 2024
Merged

Update to 1.106.1 #99

merged 6 commits into from
Jun 11, 2024

Conversation

Obito1903
Copy link
Contributor

The 1.106.1 release of immich remove the microservice container and the args & command overrides for the server container.

This pull request address those changes.

Copy link
Member

@bo0tzz bo0tzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! With this change, each worker now listens on a separate metrics port (meaning there are multiple bound to by the one container). See https://immich.app/docs/install/environment-variables#general for the defaults. Can you include those changes in this PR as well, making sure that both ports are in the service and have a serviceMonitor created?

@bo0tzz bo0tzz linked an issue Jun 11, 2024 that may be closed by this pull request
@Obito1903
Copy link
Contributor Author

Would it be useful to add an option to split api & microservice again as mentioned here https://immich.app/docs/administration/jobs-workers#split-workers ?

Copy link
Member

@bo0tzz bo0tzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I also have an issue for that (#94). But I think let's save that for a separate PR.

Thank you!

@bo0tzz bo0tzz merged commit 878292b into immich-app:main Jun 11, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove microservices container
2 participants