Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vmetrics extraArgs type #228

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix: vmetrics extraArgs type #228

merged 1 commit into from
Oct 11, 2024

Conversation

bo0tzz
Copy link
Member

@bo0tzz bo0tzz commented Oct 11, 2024

Apparently this has to be a string, but the helm template run in the gha checks doesn't care to flag that 🤦

Apparently this has to be a string, but the helm template run in the gha checks doesn't care to flag that 🤦
@bo0tzz bo0tzz enabled auto-merge (squash) October 11, 2024 09:26
Copy link

--- kubernetes/apps/monitoring/victoria-metrics/app Kustomization: flux-system/victoria-metrics HelmRelease: monitoring/victoria-metrics

+++ kubernetes/apps/monitoring/victoria-metrics/app Kustomization: flux-system/victoria-metrics HelmRelease: monitoring/victoria-metrics

@@ -44,9 +44,9 @@

       enabled: false
     vmalert:
       enabled: false
     vmsingle:
       spec:
         extraArgs:
-          search.maxUniqueTimeseries: 600000
+          search.maxUniqueTimeseries: '600000'
         resources: {}
 

Copy link

--- HelmRelease: monitoring/victoria-metrics VMSingle: monitoring/vmetrics

+++ HelmRelease: monitoring/victoria-metrics VMSingle: monitoring/vmetrics

@@ -7,13 +7,13 @@

   labels:
     app.kubernetes.io/instance: victoria-metrics
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: victoria-metrics-k8s-stack
 spec:
   extraArgs:
-    search.maxUniqueTimeseries: 600000
+    search.maxUniqueTimeseries: '600000'
   image:
     tag: v1.104.0
   license: {}
   port: '8429'
   replicaCount: 1
   resources: {}
--- HelmRelease: monitoring/victoria-metrics ValidatingWebhookConfiguration: monitoring/victoria-metrics-victoria-metrics-operator-admission

+++ HelmRelease: monitoring/victoria-metrics ValidatingWebhookConfiguration: monitoring/victoria-metrics-victoria-metrics-operator-admission

@@ -11,13 +11,13 @@

 - clientConfig:
     service:
       namespace: monitoring
       name: victoria-metrics-victoria-metrics-operator
       path: /validate-operator-victoriametrics-com-v1beta1-vlogs
       port: 9443
-    caBundle: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSURIakNDQWdhZ0F3SUJBZ0lSQU5qYk96OU55bW9aQi95UDZGTkp0MDR3RFFZSktvWklodmNOQVFFTEJRQXcKR1RFWE1CVUdBMVVFQXhNT2RtMHRiM0JsY21GMGIzSXRZMkV3SGhjTk1qUXhNREV4TURreU5qUXhXaGNOTXpReApNREE1TURreU5qUXhXakFaTVJjd0ZRWURWUVFERXc1MmJTMXZjR1Z5WVhSdmNpMWpZVENDQVNJd0RRWUpLb1pJCmh2Y05BUUVCQlFBRGdnRVBBRENDQVFvQ2dnRUJBTEpnNHlwbTByb2JOYXc0VlJQb2JzeEhuSFl3RXBKajg4cU0KMm5xR1l1Y0ZXdkUwaDMwdTZZNDVQN3Zpank4YjRnUU5hak1CUUlWNXdZN2dxTnhia01iRXlWa1BxVmlMTG5vMQpjakF5a1BYNXpGNFUvSm9JM241dy9jUVpFMjVzTG5xcVJTV3hwY3kvbTNzQlJXS2V1NGlJU1U3ZlBNSUdSV01LCndzZGU2SEtncllTd25DL3lpVHlsMFlLZTdPWURMRC9jZGlWN1RLZnFqRVNpZmJiazV5amNDbVVDeDFMSzVHakcKVHdQNE1scFB5TU9acTd5T3RudFg5N1pmY3FsWDMycmVqT2RyKzJ4MDcxZU9QUFJqb2tkaHJpVTJRd1dpZG1MSApUMDdGVDIrczZnQnNqOXNaS0tEcWk5dHRjbTlTcTM2Vnd6N1VNSFVBMW1Sa3VMV0E2NzhDQXdFQUFhTmhNRjh3CkRnWURWUjBQQVFIL0JBUURBZ0trTUIwR0ExVWRKUVFXTUJRR0NDc0dBUVVGQndNQkJnZ3JCZ0VGQlFjREFqQVAKQmdOVkhSTUJBZjhFQlRBREFRSC9NQjBHQTFVZERnUVdCQlRsL0F2SVZMWnMzS3VEZ2NRbFdBYlppcFF6Y2pBTgpCZ2txaGtpRzl3MEJBUXNGQUFPQ0FRRUFlZFphR2piUnpOUkN4c1Z4djgzUjZzekVyV3NudjdPS0hBODhCUGEwCjBzQ3J1MWNCSURsVG9QL3FxbFNwK29MWEdWNFFaa0VuTDdJTk1EUE9VKzM0S05hY2xiRXF0MnNtaFVPbWtWczEKN29EaEVxcXlPcTV2cTgwN3gwZVhCMU11OVZha1VDM3JIM1dNeVdWNjZrazBlZXFqVzhPTnY2VU9VYVNqdGVyQwpLT1RWS05hZ0l0M3gwa002WkFheS9zUmc2ZXZHSlUrZ0Q4dFlGOUdZbjFDNDhKelFSYm1GMlUyOU52UlFwNG9KClFUaytLQUZpeWR1TzI3TWoyMVdSRW5KR3NlQ3Z1eDJyaXl0cmhmRjd0MTF4dm1reE45V2Q1eUFrcEk2STdxdVEKREZUZDRkTGpCOHd5RkpLUnpjRUJESExkTE1BVDJGNEJzMnphUW94UlBkM0YrZz09Ci0tLS0tRU5EIENFUlRJRklDQVRFLS0tLS0K
+    caBundle: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSURIVENDQWdXZ0F3SUJBZ0lRZE91eStxR1FDeG1qRElRb1V4VmdqVEFOQmdrcWhraUc5dzBCQVFzRkFEQVoKTVJjd0ZRWURWUVFERXc1MmJTMXZjR1Z5WVhSdmNpMWpZVEFlRncweU5ERXdNVEV3T1RJMk5ERmFGdzB6TkRFdwpNRGt3T1RJMk5ERmFNQmt4RnpBVkJnTlZCQU1URG5adExXOXdaWEpoZEc5eUxXTmhNSUlCSWpBTkJna3Foa2lHCjl3MEJBUUVGQUFPQ0FROEFNSUlCQ2dLQ0FRRUF5cE5EeTdKQTV1emhEN1I3SjQ1bjREL2RYMldYSXZSajRnZ0gKWG8zNnp6cVVkMTJCTzRzL0J0dGdKMnd6ZnhrK1RqNFJGRjErUDFyNXRmVm10cmQ4WEpMZG5iWUNNWTlhdkZNegpNL3Jvcm5wbHhGdVNhQ2MvOE1GVzlIYnNlUm1JS2x1R0xoTFQzOEttNGV2dHZ4bE96OW1KZ1pWa2k3bWhnRk9rCjFKMnZ0bm5GbHNrTERkK3FuWnV4aVI3RzY0NUlIZVpyOFRxcDY1N0ZhMjlqSHhYRXdIUjZ4SlpTMFVBaUhiZ04KSHlJZ1BOc0p1WHYvdXNhM1hsSHc2MkRSck93OTVSKzdjNTR0RWZzdnNhOUVLdTMyUXFjU3FIVXVuckNlZ3NhVQpWaDZSYnJMaTdsc2V6WlhNMEd0dU50VG1lK1JGSEtmQVpsclNNcHI3OTBtTHUyS0dTUUlEQVFBQm8yRXdYekFPCkJnTlZIUThCQWY4RUJBTUNBcVF3SFFZRFZSMGxCQll3RkFZSUt3WUJCUVVIQXdFR0NDc0dBUVVGQndNQ01BOEcKQTFVZEV3RUIvd1FGTUFNQkFmOHdIUVlEVlIwT0JCWUVGT3EzVkpaK1ZiSWJib1p3dy9LWEtYb1BDSHFnTUEwRwpDU3FHU0liM0RRRUJDd1VBQTRJQkFRQ3JzQit0N1U5c2tyVmtPZUQzVmNiUWk0cVFzd01DRzFHQklGbXJMZEJoCmJZTTFvcDJOUkxoMmxJdzVoZFFiSm4reDFTNmVrMVJiYmFsUUNzNGlsaDZ0Mk1JUmIvdHlsdVlUbWJLeC9RWjUKaWRJbHduS3RrQnZmSTdPT0VvOXo3RXlaSTN4V0xGRHEzamgvU0h0WW5NRm9NLysyd2F4d29OajhRck81QVozTgp3TEtlQmdkUFZwVzZhUDYyTkI0YkZkV3BLVjZLR2FmVGFndDJxNU14UUFrRUtpd0xwM0ZUaGl5V0tTZ0l5RTlTCnZ4K1dJcWF2YkJrdWZORXY3QW5rZXkzRHBPaG9WQWM3TS8zbWVQaDBLdExNakdWQ0RVUDZ3ejB0NUs4aFB1ZC8KLzFDWkJzbytVNkh4TWpYZjNqeXlkVmRWTGh5SjQrR2pJR1lWam1Ka3kxRVkKLS0tLS1FTkQgQ0VSVElGSUNBVEUtLS0tLQo=
   failurePolicy: Fail
   name: vlogs.victoriametrics.com
   admissionReviewVersions:
   - v1
   - v1beta1
   sideEffects: None
@@ -40,13 +40,13 @@

 - clientConfig:
     service:
       namespace: monitoring
       name: victoria-metrics-victoria-metrics-operator
       path: /validate-operator-victoriametrics-com-v1beta1-vmagent
       port: 9443
-    caBundle: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSURIakNDQWdhZ0F3SUJBZ0lSQU5qYk96OU55bW9aQi95UDZGTkp0MDR3RFFZSktvWklodmNOQVFFTEJRQXcKR1RFWE1CVUdBMVVFQXhNT2RtMHRiM0JsY21GMGIzSXRZMkV3SGhjTk1qUXhNREV4TURreU5qUXhXaGNOTXpReApNREE1TURreU5qUXhXakFaTVJjd0ZRWURWUVFERXc1MmJTMXZjR1Z5WVhSdmNpMWpZVENDQVNJd0RRWUpLb1pJCmh2Y05BUUVCQlFBRGdnRVBBRENDQVFvQ2dnRUJBTEpnNHlwbTByb2JOYXc0VlJQb2JzeEhuSFl3RXBKajg4cU0KMm5xR1l1Y0ZXdkUwaDMwdTZZNDVQN3Zpank4YjRnUU5hak1CUUlWNXdZN2dxTnhia01iRXlWa1BxVmlMTG5vMQpjakF5a1BYNXpGNFUvSm9JM241dy9jUVpFMjVzTG5xcVJTV3hwY3kvbTNzQlJXS2V1NGlJU1U3ZlBNSUdSV01LCndzZGU2SEtncllTd25DL3lpVHlsMFlLZTdPWURMRC9jZGlWN1RLZnFqRVNpZmJiazV5amNDbVVDeDFMSzVHakcKVHdQNE1scFB5TU9acTd5T3RudFg5N1pmY3FsWDMycmVqT2RyKzJ4MDcxZU9QUFJqb2tkaHJpVTJRd1dpZG1MSApUMDdGVDIrczZnQnNqOXNaS0tEcWk5dHRjbTlTcTM2Vnd6N1VNSFVBMW1Sa3VMV0E2NzhDQXdFQUFhTmhNRjh3CkRnWURWUjBQQVFIL0JBUURBZ0trTUIwR0ExVWRKUVFXTUJRR0NDc0dBUVVGQndNQkJnZ3JCZ0VGQlFjREFqQVAKQmdOVkhSTUJBZjhFQlRBREFRSC9NQjBHQTFVZERnUVdCQlRsL0F2SVZMWnMzS3VEZ2NRbFdBYlppcFF6Y2pBTgpCZ2txaGtpRzl3MEJBUXNGQUFPQ0FRRUFlZFphR2piUnpOUkN4c1Z4djgzUjZzekVyV3NudjdPS0hBODhCUGEwCjBzQ3J1MWNCSURsVG9QL3FxbFNwK29MWEdWNFFaa0VuTDdJTk1EUE9VKzM0S05hY2xiRXF0MnNtaFVPbWtWczEKN29EaEVxcXlPcTV2cTgwN3gwZVhCMU11OVZha1VDM3JIM1dNeVdWNjZrazBlZXFqVzhPTnY2VU9VYVNqdGVyQwpLT1RWS05hZ0l0M3gwa002WkFheS9zUmc2ZXZHSlUrZ0Q4dFlGOUdZbjFDNDhKelFSYm1GMlUyOU52UlFwNG9KClFUaytLQUZpeWR1TzI3TWoyMVdSRW5KR3NlQ3Z1eDJyaXl0cmhmRjd0MTF4dm1reE45V2Q1eUFrcEk2STdxdVEKREZUZDRkTGpCOHd5RkpLUnpjRUJESExkTE1BVDJGNEJzMnphUW94UlBkM0YrZz09Ci0tLS0tRU5EIENFUlRJRklDQVRFLS0tLS0K
+    caBundle: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSURIVENDQWdXZ0F3SUJBZ0lRZE91eStxR1FDeG1qRElRb1V4VmdqVEFOQmdrcWhraUc5dzBCQVFzRkFEQVoKTVJjd0ZRWURWUVFERXc1MmJTMXZjR1Z5WVhSdmNpMWpZVEFlRncweU5ERXdNVEV3T1RJMk5ERmFGdzB6TkRFdwpNRGt3T1RJMk5ERmFNQmt4RnpBVkJnTlZCQU1URG5adExXOXdaWEpoZEc5eUxXTmhNSUlCSWpBTkJna3Foa2lHCjl3MEJBUUVGQUFPQ0FROEFNSUlCQ2dLQ0FRRUF5cE5EeTdKQTV1emhEN1I3SjQ1bjREL2RYMldYSXZSajRnZ0gKWG8zNnp6cVVkMTJCTzRzL0J0dGdKMnd6ZnhrK1RqNFJGRjErUDFyNXRmVm10cmQ4WEpMZG5iWUNNWTlhdkZNegpNL3Jvcm5wbHhGdVNhQ2MvOE1GVzlIYnNlUm1JS2x1R0xoTFQzOEttNGV2dHZ4bE96OW1KZ1pWa2k3bWhnRk9rCjFKMnZ0bm5GbHNrTERkK3FuWnV4aVI3RzY0NUlIZVpyOFRxcDY1N0ZhMjlqSHhYRXdIUjZ4SlpTMFVBaUhiZ04KSHlJZ1BOc0p1WHYvdXNhM1hsSHc2MkRSck93OTVSKzdjNTR0RWZzdnNhOUVLdTMyUXFjU3FIVXVuckNlZ3NhVQpWaDZSYnJMaTdsc2V6WlhNMEd0dU50VG1lK1JGSEtmQVpsclNNcHI3OTBtTHUyS0dTUUlEQVFBQm8yRXdYekFPCkJnTlZIUThCQWY4RUJBTUNBcVF3SFFZRFZSMGxCQll3RkFZSUt3WUJCUVVIQXdFR0NDc0dBUVVGQndNQ01BOEcKQTFVZEV3RUIvd1FGTUFNQkFmOHdIUVlEVlIwT0JCWUVGT3EzVkpaK1ZiSWJib1p3dy9LWEtYb1BDSHFnTUEwRwpDU3FHU0liM0RRRUJDd1VBQTRJQkFRQ3JzQit0N1U5c2tyVmtPZUQzVmNiUWk0cVFzd01DRzFHQklGbXJMZEJoCmJZTTFvcDJOUkxoMmxJdzVoZFFiSm4reDFTNmVrMVJiYmFsUUNzNGlsaDZ0Mk1JUmIvdHlsdVlUbWJLeC9RWjUKaWRJbHduS3RrQnZmSTdPT0VvOXo3RXlaSTN4V0xGRHEzamgvU0h0WW5NRm9NLysyd2F4d29OajhRck81QVozTgp3TEtlQmdkUFZwVzZhUDYyTkI0YkZkV3BLVjZLR2FmVGFndDJxNU14UUFrRUtpd0xwM0ZUaGl5V0tTZ0l5RTlTCnZ4K1dJcWF2YkJrdWZORXY3QW5rZXkzRHBPaG9WQWM3TS8zbWVQaDBLdExNakdWQ0RVUDZ3ejB0NUs4aFB1ZC8KLzFDWkJzbytVNkh4TWpYZjNqeXlkVmRWTGh5SjQrR2pJR1lWam1Ka3kxRVkKLS0tLS1FTkQgQ0VSVElGSUNBVEUtLS0tLQo=
   failurePolicy: Fail
   name: vmagent.victoriametrics.com
   admissionReviewVersions:
   - v1
   - v1beta1
   sideEffects: None
@@ -69,13 +69,13 @@

 - clientConfig:
     service:
       namespace: monitoring
       name: victoria-metrics-victoria-metrics-operator
       path: /validate-operator-victoriametrics-com-v1beta1-vmalert
       port: 9443
-    caBundle: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSURIakNDQWdhZ0F3SUJBZ0lSQU5qYk96OU55bW9aQi95UDZGTkp0MDR3RFFZSktvWklodmNOQVFFTEJRQXcKR1RFWE1CVUdBMVVFQXhNT2RtMHRiM0JsY21GMGIzSXRZMkV3SGhjTk1qUXhNREV4TURreU5qUXhXaGNOTXpReApNREE1TURreU5qUXhXakFaTVJjd0ZRWURWUVFERXc1MmJTMXZjR1Z5WVhSdmNpMWpZVENDQVNJd0RRWUpLb1pJCmh2Y05BUUVCQlFBRGdnRVBBRENDQVFvQ2dnRUJBTEpnNHlwbTByb2JOYXc0VlJQb2JzeEhuSFl3RXBKajg4cU0KMm5xR1l1Y0ZXdkUwaDMwdTZZNDVQN3Zpank4YjRnUU5hak1CUUlWNXdZN2dxTnhia01iRXlWa1BxVmlMTG5vMQpjakF5a1BYNXpGNFUvSm9JM241dy9jUVpFMjVzTG5xcVJTV3hwY3kvbTNzQlJXS2V1NGlJU1U3ZlBNSUdSV01LCndzZGU2SEtncllTd25DL3lpVHlsMFlLZTdPWURMRC9jZGlWN1RLZnFqRVNpZmJiazV5amNDbVVDeDFMSzVHakcKVHdQNE1scFB5TU9acTd5T3RudFg5N1pmY3FsWDMycmVqT2RyKzJ4MDcxZU9QUFJqb2tkaHJpVTJRd1dpZG1MSApUMDdGVDIrczZnQnNqOXNaS0tEcWk5dHRjbTlTcTM2Vnd6N1VNSFVBMW1Sa3VMV0E2NzhDQXdFQUFhTmhNRjh3CkRnWURWUjBQQVFIL0JBUURBZ0trTUIwR0ExVWRKUVFXTUJRR0NDc0dBUVVGQndNQkJnZ3JCZ0VGQlFjREFqQVAKQmdOVkhSTUJBZjhFQlRBREFRSC9NQjBHQTFVZERnUVdCQlRsL0F2SVZMWnMzS3VEZ2NRbFdBYlppcFF6Y2pBTgpCZ2txaGtpRzl3MEJBUXNGQUFPQ0FRRUFlZFphR2piUnpOUkN4c1Z4djgzUjZzekVyV3NudjdPS0hBODhCUGEwCjBzQ3J1MWNCSURsVG9QL3FxbFNwK29MWEdWNFFaa0VuTDdJTk1EUE9VKzM0S05hY2xiRXF0MnNtaFVPbWtWczEKN29EaEVxcXlPcTV2cTgwN3gwZVhCMU11OVZha1VDM3JIM1dNeVdWNjZrazBlZXFqVzhPTnY2VU9VYVNqdGVyQwpLT1RWS05hZ0l0M3gwa002WkFheS9zUmc2ZXZHSlUrZ0Q4dFlGOUdZbjFDNDhKelFSYm1GMlUyOU52UlFwNG9KClFUaytLQUZpeWR1TzI3TWoyMVdSRW5KR3NlQ3Z1eDJyaXl0cmhmRjd0MTF4dm1reE45V2Q1eUFrcEk2STdxdVEKREZUZDRkTGpCOHd5RkpLUnpjRUJESExkTE1BVDJGNEJzMnphUW94UlBkM0YrZz09Ci0tLS0tRU5EIENFUlRJRklDQVRFLS0tLS0K
[Diff truncated by flux-local]

@bo0tzz bo0tzz merged commit 4fa3cf1 into main Oct 11, 2024
2 checks passed
@bo0tzz bo0tzz deleted the fix/vm-args-type branch October 11, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants