Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: intel compute runtime packages #102

Merged
merged 3 commits into from
Sep 6, 2024
Merged

fix: intel compute runtime packages #102

merged 3 commits into from
Sep 6, 2024

Conversation

bo0tzz
Copy link
Member

@bo0tzz bo0tzz commented Aug 20, 2024

@bo0tzz bo0tzz marked this pull request as draft August 20, 2024 12:36
@bo0tzz bo0tzz force-pushed the fix/intel-runtime branch 4 times, most recently from 6432c91 to d0a0e36 Compare August 20, 2024 13:14
@bo0tzz bo0tzz marked this pull request as ready for review August 20, 2024 13:18
Copy link
Contributor

@mertalev mertalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is removing other dependencies we also get from sid. It should only remove intel-opencl-icd from the command.

server/Dockerfile Outdated Show resolved Hide resolved
@bo0tzz bo0tzz force-pushed the fix/intel-runtime branch 3 times, most recently from 1559415 to 8204fb7 Compare August 20, 2024 13:49
@bo0tzz bo0tzz requested a review from mertalev August 20, 2024 13:49
mertalev
mertalev previously approved these changes Aug 20, 2024
@mertalev mertalev dismissed their stale review August 20, 2024 14:12

libwebp shouldn't be installed from stable.

server/bin/configure-apt.sh Outdated Show resolved Hide resolved
Comment on lines 113 to 104
RUN if [ $(arch) = "x86_64" ]; then \
wget https://github.com/intel/intel-graphics-compiler/releases/download/igc-1.0.17193.4/intel-igc-core_1.0.17193.4_amd64.deb && \
wget https://github.com/intel/intel-graphics-compiler/releases/download/igc-1.0.17193.4/intel-igc-opencl_1.0.17193.4_amd64.deb && \
wget https://github.com/intel/compute-runtime/releases/download/24.26.30049.6/intel-opencl-icd-dbgsym_24.26.30049.6_amd64.ddeb && \
wget https://github.com/intel/compute-runtime/releases/download/24.26.30049.6/intel-opencl-icd_24.26.30049.6_amd64.deb && \
wget https://github.com/intel/compute-runtime/releases/download/24.26.30049.6/libigdgmm12_22.3.20_amd64.deb && \
dpkg -i *.deb && \
apt-get install -t testing --no-install-recommends -yqq intel-media-va-driver-non-free && \
rm *.deb; \
fi && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like it, it's hard to tell if there are any missing dependencies.

I have something like this for the AIO image, which comes from linuxserver:

  if [ $(arch) = "x86_64" ]; then \
    echo "**** install intel dependencies ****" && \
    apt-get install --no-install-recommends -y \
      intel-media-va-driver-non-free \
      ocl-icd-libopencl1 && \
    INTEL_DEPENDENCIES=$(curl -sX GET "https://api.github.com/repos/intel/compute-runtime/releases/latest" | jq -r '.body' | grep wget | grep -v .sum | grep -v .ddeb | sed 's|wget ||g') && \
    mkdir -p /tmp/intel && \
    for i in $INTEL_DEPENDENCIES; do \
      curl -fS --retry 3 --retry-connrefused -o \
        /tmp/intel/$(basename "${i%$'\r'}") -L \
        "${i%$'\r'}"; \
    done && \
    dpkg -i /tmp/intel/*.deb; \
  fi && \

Not sure if we need wget https://github.com/intel/compute-runtime/releases/download/24.26.30049.6/intel-opencl-icd-dbgsym_24.26.30049.6_amd64.ddeb, it's not installed by dpkg -i *.deb

Copy link
Contributor

@mertalev mertalev Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! I guess an advantage of this is that you can just point it at a release (or latest) without changing the specific file name of each dependency.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue is we don't want all of the dependencies from the release, maybe we could filter which ones we take though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the unused ddeb package, leaving the rest as-is for now

@mertalev mertalev merged commit d5485a1 into main Sep 6, 2024
2 checks passed
@mertalev mertalev deleted the fix/intel-runtime branch September 6, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants