Skip to content

Commit

Permalink
warning instead of error for invalid icc
Browse files Browse the repository at this point in the history
  • Loading branch information
mertalev committed Oct 31, 2024
1 parent 4ab5466 commit c13a251
Show file tree
Hide file tree
Showing 2 changed files with 40 additions and 0 deletions.
1 change: 1 addition & 0 deletions server/bin/build-libjxl.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ cd libjxl
git reset --hard "$LIBJXL_REVISION"
git submodule update --init --recursive --depth 1 --recommend-shallow
git apply ../jpegli-empty-dht-marker.patch # adapted from https://github.com/libjxl/libjxl/pull/2704
git apply ../jpegli-icc-warning.patch

mkdir build
cd build
Expand Down
39 changes: 39 additions & 0 deletions server/bin/jpegli-icc-warning.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
diff --git a/lib/jpegli/decode_marker.cc b/lib/jpegli/decode_marker.cc
index 2621ed08..33cbb8be 100644
--- a/lib/jpegli/decode_marker.cc
+++ b/lib/jpegli/decode_marker.cc
@@ -408,24 +408,29 @@ void ProcessAPP(j_decompress_ptr cinfo, const uint8_t* data, size_t len) {
payload += sizeof(kIccProfileTag);
payload_size -= sizeof(kIccProfileTag);
if (payload_size < 2) {
- JPEGLI_ERROR("ICC chunk is too small.");
+ JPEGLI_WARN("ICC chunk is too small.");
+ return;
}
uint8_t index = payload[0];
uint8_t total = payload[1];
++m->icc_index_;
if (m->icc_index_ != index) {
- JPEGLI_ERROR("Invalid ICC chunk order.");
+ JPEGLI_WARN("Invalid ICC chunk order.");
+ return;
}
if (total == 0) {
- JPEGLI_ERROR("Invalid ICC chunk total.");
+ JPEGLI_WARN("Invalid ICC chunk total.");
+ return;
}
if (m->icc_total_ == 0) {
m->icc_total_ = total;
} else if (m->icc_total_ != total) {
- JPEGLI_ERROR("Invalid ICC chunk total.");
+ JPEGLI_WARN("Invalid ICC chunk total.");
+ return;
}
if (m->icc_index_ > m->icc_total_) {
- JPEGLI_ERROR("Invalid ICC chunk index.");
+ JPEGLI_WARN("Invalid ICC chunk index.");
+ return;
}
m->icc_profile_.insert(m->icc_profile_.end(), payload + 2,
payload + payload_size);

0 comments on commit c13a251

Please sign in to comment.