Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@dc1248's fixes from #18 for pie menu appearing non-3D screens #26

Closed
wants to merge 1 commit into from

Conversation

tmilker
Copy link
Contributor

@tmilker tmilker commented Dec 2, 2023

This commit is @dc1248's fixes for the issue with the Z pie menu appearing on screens other than the 3D view and not allowing the z key to be pressed in the Script editor. I changed the variable name to be slightly more accurate than _is_active. I also chose it to be true by default since typically Godot opens with the 3D view. This has the side effect of it always working the first time so if you disable/enable the plugin in the Script editor, it will still appear. However, setting it to false means that it never works the first time when you're in the 3D view, which feels worse since the former situation is a lot less likely.

I tried fixing #19, where pressing the Z button again causes the pie menu to disappear but the options are still present and invisible until you press the Escape key. I don't know enough about Godot. I think if the item_cancelled signal could be sent to the pie menu too, that would fix it.

@tmilker
Copy link
Contributor Author

tmilker commented Dec 9, 2023

Well, this still blocks the letter z input in the Inspectors and other areas, so I need to figure out how to make it more specific to just the 3D view I guess.

@tmilker tmilker closed this Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant