-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split ranger binary into lib and binary. #40
Open
0x7f
wants to merge
362
commits into
imbs-hl:master
Choose a base branch
from
0x7f:libranger
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tree split weights (issue imbs-hl#15)
add option to keep inbag counts of observations per tree, issue imbs-hl#28
add sample.fraction option to control fraction of samples sampled, is…
Fix prediction problem
Fix bug if survival tree without OOB observations
To allow embedding the ranger functionality into other applications, move the functionality into a separate library and just put the main.cpp in the ranger binary target.
We still want this, but this PR is quite outdated. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A draft for moving the ranger functionality into its own library.
When just calling
cmake ..
, it will build a static library and when settingBUILD_SHARED_LIB
flag, i.e.cmake -DBUILD_SHARED_LIB=1 ..
, it will create a shared lib.Did not test on Windows yet where setting
__declspec(dllexport)
is missing most probably.