Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add "sibling". #437

Merged
merged 4 commits into from
Jun 30, 2021
Merged

add "sibling". #437

merged 4 commits into from
Jun 30, 2021

Conversation

crssnky
Copy link
Member

@crssnky crssnky commented May 30, 2021

ref. #404

crssnky added 2 commits May 30, 2021 10:01
@crssnky
add "sibling" to Futami.
732b9c5
@crssnky
add sibling relations.
1f0bd7c 
- 七草
- 蒼井
- 双海(1st)
- 久川
- 青木
- 大崎
@crssnky crssnky marked this pull request as ready for review May 30, 2021 03:39
HagiAyato
HagiAyato approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@HagiAyato HagiAyato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

データ間違いないことを確認しました。
追伸：トレーナー4姉妹の名前は初めて知りました

HagiAyato
HagiAyato approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@HagiAyato HagiAyato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なぜかapproveがうまくいっていなかったので再トライ

foooomio
foooomio approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@foooomio foooomio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RDF 的に問題ないことを確認したので Approve します。内容については @HagiAyato さんをのレビューを信用します。

@crssnky crssnky merged commit 9475e7d into imas:master Jun 30, 2021
@crssnky crssnky deleted the sibling branch June 30, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HagiAyato HagiAyato HagiAyato approved these changes

@foooomio foooomio foooomio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crssnky @foooomio @HagiAyato