Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update libwebp to 1.3.2 #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update libwebp to 1.3.2 #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ const pkg = JSON.parse(fs.readFileSync(new URL('../package.json', import.meta.ur
const url = `https://raw.githubusercontent.com/imagemin/cwebp-bin/v${pkg.version}/vendor/`;

const binWrapper = new BinWrapper()
.src(`${url}osx/cwebp`, 'darwin')
.src(`${url}linux/x86/cwebp`, 'linux', 'x86')
.src(`${url}osx/arm64/cwebp`, 'darwin', 'arm64')
.src(`${url}osx/x86-64/cwebp`, 'darwin', 'x86-64')
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see any documentation in bin-wrapper about recognized architectures. These are how they're referenced in macOS and Linux, but I'm happy to change them to x64 and arm64 to match if that will work.

.src(`${url}linux/aarch64/cwebp`, 'linux', 'aarch64')
.src(`${url}linux/x64/cwebp`, 'linux', 'x64')
.src(`${url}win/x64/cwebp.exe`, 'win32', 'x64')
.dest(fileURLToPath(new URL('../vendor', import.meta.url)))
Expand Down
2 changes: 1 addition & 1 deletion lib/install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ bin.run(['-version']).then(() => {
console.info('compiling from source');

try {
const source = fileURLToPath(new URL('../vendor/source/libwebp-1.2.1.tar.gz', import.meta.url));
const source = fileURLToPath(new URL('../vendor/source/libwebp-1.3.2.tar.gz', import.meta.url));

binBuild.file(source, [
`./configure --disable-shared --prefix="${bin.dest()}" --bindir="${bin.dest()}"`,
Expand Down
2 changes: 1 addition & 1 deletion test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ test('rebuild the cwebp binaries', async t => {
}

const temporary = temporaryDirectory();
const source = fileURLToPath(new URL('../vendor/source/libwebp-1.2.1.tar.gz', import.meta.url));
const source = fileURLToPath(new URL('../vendor/source/libwebp-1.3.2.tar.gz', import.meta.url));

await binBuild.file(source, [
`./configure --disable-shared --prefix="${temporary}" --bindir="${temporary}"`,
Expand Down
Binary file added vendor/linux/aarch64/cwebp
View file
Open in desktop
Binary file not shown.
Binary file modified vendor/linux/x64/cwebp
View file
Open in desktop
Binary file not shown.
Binary file removed vendor/linux/x86/cwebp
View file
Open in desktop
Binary file not shown.
Binary file added vendor/osx/arm64/cwebp
View file
Open in desktop
Binary file not shown.
Binary file removed vendor/osx/cwebp
View file
Open in desktop
Binary file not shown.
Binary file added vendor/osx/x86-64/cwebp
View file
Open in desktop
Binary file not shown.
Binary file renamed vendor/source/libwebp-1.2.1.tar.gz → vendor/source/libwebp-1.3.2.tar.gz
View file
Open in desktop
Binary file not shown.
Binary file modified vendor/win/x64/cwebp.exe
View file
Open in desktop
Binary file not shown.
Loading