feat: geocoding (main) #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 25, 2023
Merged
|
I am a bot, here are the test results for this PR:
|
hydazz
approved these changes
Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Immich relies on a npm package for retrieving city and country names based on geographical coordinates. However this package has been associated with potential crashes and excessive RAM usage. In response to these issues, there is an open PR to transition away from this package by incorporating a more stable approach (by loading the geocoding data into a PostgreSQL table). But the geocoding data is not loaded when the server starts like it's done currently with the npm package but when the image is built.
This PR adds the geocoding data during the build, you can see here how it's done with the Immich base image