This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
Use Rust's #[non_exhaustive] lint for enums #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fintelia Have we discussed the MSRV policy for |
HeroicKatora
changed the title
|
Non-exhaustive was stablized in Rust 1.22.0: https://github.com/rust-lang/rust/pull/45394/files#diff-8fe611e80215042c8d89714f4dd6f8baR390 (if I am correct) |
|
It was introduced in |
|
Otherwise we'd be using it in |
|
The main concern just comes down to not disrupting users of the main image crate when we make that one depend on image-core |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust provides its own
#[non_exhaustive]lint after RFC 2008. Use compiler provided guarantee could make better docs, and a better way for pattern matching without breaking backward compability.To make a proof of concept of usage, users may need to create another crate. Within one crate (a.k.a. the
image-coreitself) thenon_exhaustiveonly behaves like normal enums. But in other crates if we need to use this enum (e.g. other crate useimage-core's enum), there should always be a reserved_arm on match blocks whenever all arms are already covered.This change should be zero-cost with the original way. (If I am incorrect, please reply and inform me, thanks :)