-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert indexed data into RGB data #23
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR! Can you please remove the second commit? Our repositories expect npm7+ to be present (peer dependencies are installed automatically with it). |
I'll have a closer look at the code in a few days, as the implementation is quite different than the one I did in |
@targos Thanks. Waiting for your review. |
Done But in my case, it breaks https://github.com/microshine/fast-png/runs/4118047939?check_suite_focus=true |
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
+ Coverage 90.57% 90.68% +0.11%
==========================================
Files 6 6
Lines 403 440 +37
Branches 79 86 +7
==========================================
+ Hits 365 399 +34
- Misses 38 41 +3
Continue to review full report at Codecov.
|
The Prettier errors can be fixed with |
@targos Thank you for the advice. I fixed it |
Hi.
I added
rgb
method toindex.js
file. It allows converting indexed data into RGB dataExample of usage