Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even more functionality #27

Merged
merged 11 commits into from
Apr 11, 2024
Merged

Even more functionality #27

merged 11 commits into from
Apr 11, 2024

Conversation

StephenMachete
Copy link
Contributor

New import_audio() with bugfix
Added create_new_tracks()
Added set_timeline_selection()

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 88.96%. Comparing base (a6145b0) to head (00da85c).
Report is 13 commits behind head on master.

❗ Current head 00da85c differs from pull request most recent head 711531c. Consider uploading reports for the commit 711531c to get more accurate results

Files Patch % Lines
ptsl/engine.py 23.07% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage   89.48%   88.96%   -0.52%     
==========================================
  Files          80       82       +2     
  Lines        1398     1423      +25     
==========================================
+ Hits         1251     1266      +15     
- Misses        147      157      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iluvcapra
Copy link
Owner

@StephenMachete Hey try running autopep8 on the files you've changed, that will take care of a lot of these lint issues. Once you've done that we can add a few unit tests so the coverage doesn't go down.

@iluvcapra
Copy link
Owner

Still some failures here, I use vim and what I usually do I I run flake8 in a vsplit buffer and just check off the errors one-by-one, it's the easiest way to hit these.

@StephenMachete
Copy link
Contributor Author

Thanks for the patience, i think i got it now..
I installed flake8(now i know :D) and fixed all error, except the "Line too long" things.
I think its perfectly fine and readable, i don't really know how to structure it to not hit the Line too long things.
Also further fixed some code. Optional and standard value logic should be correct now(not just working :D)

@iluvcapra iluvcapra mentioned this pull request Apr 11, 2024
@iluvcapra iluvcapra merged commit 711531c into iluvcapra:master Apr 11, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants