This repository has been archived by the owner on Apr 24, 2022. It is now read-only.
Fix top and bottom for iphone X #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change installs a collection view for content, another collection view for tab content, a stack view to house the tab collection view. The stack view later will be used to include an active tab indicator view.
This change does a lot. 😅 After the initial layout implementation, this change implements view controller fetching from the data source and presenting the contents in the content collection view. Although, custom content layout for paging is yet to be implemented.
This change implements the tab bar contents. Although, custom tab layout for paging and active tab indicator are yet to be implemented.
I assumed keeping a weak reference to the content view controller would be fine, but turns out collection view might not call data source function cellForItemAt:IndexPath to let me configure the cell again with the view controller, because it’s already cached.
This change introduces ScrollController that will be responsible for communication between content and tab collection views. Also with this change we already have content selection over tab collection view, but we still have some work to do for tab and content tracking.
This change allows the client to configure tab width to be either fixed or flexible to fill the full width. Auto sizing is planned for future development.
This change explicitly passes the nib name and bundle in init function fixing the case where ViewPagerController is bundled within a framework.
* commit 'd32bde206c02f96ef3d4e5d9c13530f724f2f637': (23 commits) Fix ViewPagerController init Minor refactors Fix empty data source case Update Readme Add customizable color support for tab indicator Update Readme Update Readme Remove legacy code base Add tab item sizing policy Implement tab indicator Fine tune scrolling on content collection view Implement scroll on tab bar when content scrolls Disable bouncing for collection views Add numbers to example scenes Implement ScrollController Set background color for ViewPagerController Implement paging layout Fix for view controller embedding Implement initial tab bar Implement initial view controller embedding ... # Conflicts: # ICViewPager/ICViewPager/ViewPagerController.m
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I change some code in ViewPagerController.m now ICViewPager work fine on the new iPhone X