Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node-local domain decomp #968

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Node-local domain decomp #968

wants to merge 16 commits into from

Conversation

MTCam
Copy link
Member

@MTCam MTCam commented Sep 7, 2023

This change set brings changes from @majosm's fork (majosm@a444cdd), which makes mesh partitioning a node-local affair. Each physical compute node gets the mesh data (read from gmsh or generated) and locally partitions and distributes the mesh partitions among the ranks local to the physical compute node.

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@majosm majosm mentioned this pull request Sep 7, 2023
8 tasks
Copy link
Collaborator

@majosm majosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look through the code to see if the node-local code is up to date. Looks like it is, apart from one comment. This version also has the correct indentation for part_id_to_tag_to_elements.

mirgecom/simutil.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants