Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert that we pass an actual comm_tag #818

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

matthiasdiener
Copy link
Member

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@MTCam
Copy link
Member

MTCam commented Jan 12, 2023

Question: Would it be better to just require the comm_tag argument instead of defaulting to None and then complaining when it takes the default value?

@inducer
Copy link
Contributor

inducer commented Jan 12, 2023

Question: Would it be better to just require the comm_tag argument instead of defaulting to None and then complaining when it takes the default value?

I think that would be better, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants