Remove Programs render modifiers #8189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelchadwick
requested review from
jrjohnson and
stopfstedt
as code owners
stopfstedt
reviewed
Oct 19, 2024
| } | ||
|
|
||
| // @action |
stopfstedt
requested changes
Oct 19, 2024
| @action | ||
| load(element, [programYear]) { | ||
| this.objectiveCount = programYear.hasMany('programYearObjectives').ids().length; | ||
| constructor() { |
There was a problem hiding this comment.
this can be further simplified. we don't need to set objectiveCount as component attribute.
instead, a getter would suffice here:
Suggested change
| constructor() { | |
| get objectivesCount() { | |
| return this.args.programYear.hasMany('programYearObjectives').ids().length; | |
| } |
then, remove the tracked property by the same name further up in the class, and we're good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs ilios/ilios#5374