main-list mixin consistency #8187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelchadwick
requested review from
jrjohnson and
stopfstedt
as code owners
michaelchadwick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ilios/ilios#5759
This PR got a whole lot more complicated than I thought, but it was needed to fix the issue.
The
mixins/main-list.scssmixin file is infrontend, but had a mixin that needed to be called byilios-common, so...I moved it! :-O This, of course, broke a lot of@imports, so I had to fix them. In the end, I was able to make the "you made a new thing" template chunk's class more consistent.No idea why changing
.save-result->.saved-result(to be consistent with every other instance of this kind of thing) in Courses->Sessions breaks that route (gives me a Zoinks!), so I changed it back for now.