Reports->Terms->Program Year title fixed

[michaelchadwick]

Fixes ilios/ilios#4934

[michaelchadwick]

For some reason, the "year" part of the auto-generated report title only loads properly once the report has been accessed once.

To reproduce:

1. Go to /reports
2. Create a report like the following:

3. Save report
4. There should be a saved report called All Terms for 2018 Doctor of Medicine in Medicine
5. Reload site
6. Notice it now says All Terms for Doctor of Medicine in Medicine
7. Click on report
8. Click on "Back to Reports" or anywhere else on the site, really
9. Notice how it says the correct title again

As long as you don't reload/refresh the site, it says the correct report title. Is this not being saved in the database somewhere? If so, then it isn't loading something correctly.

@jrjohnson any ideas?

[jrjohnson]

This needs a test.

Not ready to review yet

[jrjohnson]

This is a reactivity mess. Basically you just shouldn't use classOfYear and we should probably deprecated and remove it. What is happening is that programYear.classOfYear seems like a property, but it's actually doing some async behind the scenes. When you access it when the program isn't loaded yet it returns an empty string. What usually happens is that the program then loads and whatever getter accessed the value updates. That's a mouthful and hard to type. In this case there isn't a getter so Ember's auto tracking isn't happening, it's being resolved into this object as an empty string. The next time you access it if works because the program is resolved in the classOfYear getter.

I'll add a line comment for a solution here, but let's connect live and talk about this because it's a gotcha that needs discussion and then removal.

[jrjohnson]

And for sure needs some tests to make sure it doesn't recur again.

[jrjohnson]

I may be wrong, but I think the extra description is not needed.