Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nav-links in flyout now sticky and stay on top when page scrolled down #8168

Merged

Conversation

michaelchadwick
Copy link
Contributor

@michaelchadwick
Copy link
Contributor Author

Btw, the bottom: 0 was required for Firefox (top: 0 seemed to be good enough for Chrome) to not have vertical-alignment glitches when resizing the browser window.

@jrjohnson
Copy link
Member

I'm not getting any stickiness at all in Safari 18.0
Screenshot 2024-09-30 at 9 11 31 AM

@michaelchadwick
Copy link
Contributor Author

@jrjohnson Nice catch. Fix has been made.

Copy link
Member

@jrjohnson jrjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@dartajax dartajax added the run ui tests Run the expensive UI tests label Sep 30, 2024
@michaelchadwick michaelchadwick force-pushed the frontend-4293-stick-it-to-flyout-menu branch from 0ab5419 to 169e458 Compare October 1, 2024 17:53
@dartajax dartajax merged commit 9382b39 into ilios:master Oct 1, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run ui tests Run the expensive UI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ilios Flyout Menu Should Remain Available When User Scrolls Down the Page
3 participants