Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes a couple of calls to Array.slice() where they are not needed. #8166

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

stopfstedt
Copy link
Member

refs ilios/ilios#5660

i made another pass of the frontend package and checked on any calls on slice().

$ grep -lr '\.slice()' packages/frontend | egrep -v '(dist|node_modules)' | sort
packages/frontend/app/components/courses/root.js
packages/frontend/app/components/global-search-box.js
packages/frontend/app/components/instructor-groups/list.js
packages/frontend/app/components/new-directory-user.js
packages/frontend/app/components/program-year/objective-list.js
packages/frontend/app/components/reports/subject/new/course.js
packages/frontend/app/components/reports/subject/new/session.js
packages/frontend/app/components/reports/subject/session.js
packages/frontend/app/controllers/curriculum-inventory-report/index.js
packages/frontend/tests/integration/components/program-year/list-test.js

a couple of them can be removed, the rest is necessary.

will deal with the other packages at a later time, unless someone else beats me to it.

Copy link
Contributor

@michaelchadwick michaelchadwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

De-slice()d!

@jrjohnson jrjohnson added the run ui tests Run the expensive UI tests label Sep 27, 2024
@dartajax dartajax merged commit 9452873 into ilios:master Sep 27, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run ui tests Run the expensive UI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants