Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix editable headers with extra elements #8164

Conversation

michaelchadwick
Copy link
Contributor

Fixes ilios/ilios#5730

The new <FadeText> component needs its display-text-wrapper to display: inline-block to account for other elements.

Copy link
Member

@jrjohnson jrjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! I was sure I broke this 😁

@michaelchadwick michaelchadwick added the run ui tests Run the expensive UI tests label Sep 27, 2024
@dartajax dartajax merged commit 26e80ab into ilios:master Sep 27, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run ui tests Run the expensive UI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report Edit Title Button Mis-aligned
3 participants